-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subtitle/closed caption icons #1050
Conversation
Signed-off-by: Wei Zhang <[email protected]>
for `.890`, `.cip`, `.sbv`, `.scc`, `smi`, and good old `.vtt`
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RuralAnemone The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR currently uses the first one |
rerunning tests |
I guess |
weird |
hi @RuralAnemone, sorry for the late reply, it's weird the CI keeps failing, I would look into it and make sure it's ok then merge the PR |
it should be ok; I just added some more tuples to the icons array I mean there might be a weird memory bug on windows or something but I doubt it surely that isn't 2GB yet |
how could I have forgotten srt |
add subtitle/closed caption icons
uses
U+F015E
,
for.890
,.cip
,.sbv
,.scc
,smi
, and good old.vtt
TODONEcargo fmt