DM-44453: Fix handling of release versions in v2 API. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minimal update to get Pre-commit running again. isort needed updating to work with the current pre-commit.
jonathansick
force-pushed
the
tickets/DM-44453
branch
from
c16dbf6
to
7d698e7
Compare
- Accept version tags that don't start with v. - Allow an optional patch component to support full semver versions.
jonathansick
force-pushed
the
tickets/DM-44453
branch
2 times, most recently
from
32d2d20
to
1cf5097
Compare
There's an issue building uwsgi that's stopping the type checking, but doesn't affect the pytest environments? Including build tools (build-essential) doesn't seem to help with building uwsgi. Also stop pushing to Docker Hub
The POST and PATCH endpoints for editions now allow the kind to be set.
If it is the __main slug, then the edition is always a "main" kind. Otherwise inspect the tracking git_ref to set release/major/minor kinds. Otherwise the edition is a draft.
jonathansick
force-pushed
the
tickets/DM-44453
branch
from
225cca7
to
16c7b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kindis now being automatically set based on introspection of the tracking git ref when an edition is automatically created from a build.kindis now included in the edition response models, and can be set or reset in the POST/PATCH models for an edition.lsst_doctracking mode now accepts semver tags, not just thevX.Ytags typical of Rubin documentation releases.