DM-42201: Add flat metrics for mean, noise vs mjd and FP plots #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
3 times, most recently
from
d597a35
to
9b34d29
Compare
czwa
requested changes
Nov 15, 2024
| @@ -90,16 +91,19 @@ class SingleValueRepacker(KeyedDataAction): | |||
|
|
|||
| def __call__(self, data: KeyedData, **kwargs) -> KeyedData: | |||
| repackedData = {} | |||
| uniquePanelKeys = list(set(data[self.panelKey])) | |||
| good = ~data[self.panelKey].mask | |||
There was a problem hiding this comment.
Unfortunately, I think (based on your jenkins failure), that you need to see if data is a numpy masked-array, and do the new thing, otherwise, default to the existing code. Hopefully that's not too difficult, and I'll re-check next week.
Alex-Broughton
force-pushed
the
tickets/DM-42201
branch
from
9b34d29
to
2f5df70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.