DM-47892 : Add associationCore #320
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerenjie
force-pushed
the
tickets/DM-47892
branch
from
79ceb55
to
720f516
Compare
isullivan
approved these changes
Dec 4, 2024
Comment on lines
91
to
92
| nExpectedSsObjects: ct | ||
| nAssociatedSsObjects: ct |
There was a problem hiding this comment.
It looks like these quantities were added to the task metadata previously in a different ticket, so we should use those names:
numTotalSolarSystemObjects
numAssociatedSsObjects
Comment on lines
88
to
90
| atools.calexpMetadataMetrics: MetadataMetricTool | ||
| atools.calexpMetadataMetrics.taskName: diaPipe | ||
| atools.calexpMetadataMetrics.metrics: |
There was a problem hiding this comment.
atools.calexpMetadataMetrics as used here is just a label, which references MetadataMetricTool and allows it to be configured. You can name it anything you want, so I suggest renaming to atools.diaPipeMetadataMetrics
Gerenjie
force-pushed
the
tickets/DM-47892
branch
from
720f516
to
d52e450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.