-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-47299: Add the afterburner subset to all of the pipelines #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, the instrument-specific ApVerify
should splice in the afterburner
subset from the instrument-specific ApPipe
-- as it is, the ApVerify
will drop any overrides to afterburner tasks from ap_pipe
. I'd recommend doing that for consistency's sake, even though the odds of such overrides existing are pretty low.
The problem would be if we end up overriding any of those tasks for ap_verify, like we do with diaPipe
...
861eb89
to
0f0cd15
Compare
Good point. I have moved the import to the instrument-specific |
I hope you meant copy ( |
@@ -11,6 +11,7 @@ imports: | |||
- location: $AP_PIPE_DIR/pipelines/DECam/ApPipe.yaml | |||
include: | |||
- prompt | |||
- afterburner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd need to also exclude from _ingredients/ApVerify.yaml
, else you have double definitions.
0f0cd15
to
beef219
Compare
I had moved the imports rather than copied and excluded them, but I have fixed that up now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please confirm that the final pipelines are still valid.
{Summary of changes. Prefix PR title with JIRA issue.}
scons
and/orstack-os-matrix
)?ap_verify.py
on at least one of the standard datasets?For changes to metrics, the
print_metricvalues
script fromlsst.verify
will be useful.