DM-45750: Store new-style ephemerides and APDB catalogs in ap_verify data sets #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit copies innovations from the dataset template, including canonical paths and automated management of the `sso` chained collection. These changes make it easier to apply new improvements.
The changes to this script are **untested**, because at present the MPSky service can't handle HSC.
The catalogs have the same format, differing only in dimensionality. This is less efficient than creating a per-detector catalog from scratch, but should let ap_verify data sets keep working until MPSky supports general observatories.
This script takes a long time to run, because it simulates ApPipe execution visit by visit.
These catalogs are generated visit-by-visit from scratch, so the visit 59134 catalogs are empty.
This removes the exposure, visit, and day_obs dimensions, as well as the visitSsObjects dataset type.
erinleighh
approved these changes
Oct 17, 2024
kfindeisen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reformats the solar system ephemerides, adds preloaded APDB catalogs, and provides scripts to maintain both. It should be used together with lsst/ap_verify#238 to ensure self-consistent behavior.
This PR increases the data set by less than 0.1 GiB.
ap_verify.pyon this dataset?scripts/, should those changes be propagated to ap_verify_dataset_template, or are they specific to this data set?