Clarify the message about passwords being found in HIPB #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old password was a bit vague and I believe confusing. I have tried to improve the messaging.
|
I'm not sure this should be the default message, indeed the reference to FBI seems not useful here. Note that you can easily customize the message by adding a lang file in conf/ folder. |
|
Thanks for your feedback. I know it's easy to change, but I think in the spirit of "secure by default" one should try to make the default message as useful as possible. As I think it's unlikely most users will spend the time to change any of the defaults. What do you think about the change if we would change "FBI" to something more neutral like "law enforcement agencies" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old password was a bit vague and I believe confusing. I have tried to improve the messaging.
I am aware the inclusion of FBI might be an americanism but I included it still as FBI does feed data into Have I Been Pwned (HIPB) and my thinking is that that it is well known and respected enough to gives some authority to the messaging.
I did consider "law enforcement agencies" also considered that too vague. When updating the other translations, other more local wording might be better.