Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWAT-4099][Form Validation Open Source] Fix in isFieldValid #16

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[SWAT-4099][Form Validation Open Source] Fix in isFieldValid #16

merged 2 commits into from
Oct 22, 2024

Conversation

Brian06
Copy link
Collaborator

@Brian06 Brian06 commented Oct 22, 2024 •
edited
Loading

Description

  • Fixing a small bug in the library related with getting the opposite of what was expected in the isFieldValid method.
  • Increasing version to publish

Type of Change / Changes Made

  • [List the key changes made in this PR. (e.g., below)]

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing guidelines
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes do not introduce any new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Brian06 Brian06 added the bug Something isn't working label Oct 22, 2024
@Brian06 Brian06 self-assigned this Oct 22, 2024
@Brian06 Brian06 merged commit f640879 into ltvco:main Oct 22, 2024
2 checks passed
@Brian06 Brian06 deleted the bs_SWAT-4099_fix_isFieldValid branch October 22, 2024 16:32
alsoto25 added a commit to alsoto25/form-validation-ltv-public that referenced this pull request Oct 29, 2024
@alsoto25
Squashed commit of the following:
7c8b470 
commit f640879
Author: Brian Salazar <[email protected]>
Date:   Tue Oct 22 10:32:50 2024 -0600

    [SWAT-4099][Form Validation Open Source] Fix in isFieldValid (ltvco#16)

    * fix to send the correct value

    * 1.0.2

    ---------

    Co-authored-by: Brian Salazar <[email protected]>

commit 4d02934
Author: Brian Salazar <[email protected]>
Date:   Tue Oct 22 09:19:29 2024 -0600

    [SWAT-4097] Remove all test related code (ltvco#15)

    * remove all test related code

    * remove the fix to apply it in a separate PR

    ---------

    Co-authored-by: Brian Salazar <[email protected]>

commit a51dfbe
Author: Md Mohsin <[email protected]>
Date:   Tue Oct 15 19:43:24 2024 +0530

    Added pull_request_template and created  issue templates for bug reports and feature_requests  (ltvco#12)

commit 643c385
Merge: 4ffcce2 7015f93
Author: Ale Soto <[email protected]>
Date:   Fri Sep 13 12:47:24 2024 -0600

    Merge pull request ltvco#11 from AnthonyGriffith/ag_public-methods-tests

commit 7015f93
Author: Anthony Griffith <[email protected]>
Date:   Wed Sep 11 11:42:20 2024 -0600

    add tests to all methods

commit 282d18c
Author: Anthony Griffith <[email protected]>
Date:   Wed Sep 11 11:40:50 2024 -0600

    fix method return

    the function was returning the opposite of what was intended

commit 4ffcce2
Merge: edbc384 157f604
Author: Ale Soto <[email protected]>
Date:   Wed Jul 31 09:55:47 2024 -0600

    Merge pull request ltvco#9 from alsoto25/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KennethCalvo KennethCalvo KennethCalvo approved these changes

@eric-bv eric-bv eric-bv approved these changes

@alsoto25 alsoto25 Awaiting requested review from alsoto25 alsoto25 is a code owner

Assignees

@Brian06 Brian06

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brian06 @eric-bv @KennethCalvo