APOLLO-24186 Removed schema and Get mentions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblucar
changed the title
mwmitchell
reviewed
Apr 14, 2020
java-sdk/configuration.asciidoc
Outdated
| This property would then be present in the generated schema. | ||
|
|
||
| Here is an example of the most basic configuration, along with required annotations and a sample "getter" method: | ||
| Here is an example of the most basic configuration, along with required annotations and a sample property access methods: |
There was a problem hiding this comment.
Suggested change
| Here is an example of the most basic configuration, along with required annotations and a sample property access methods: | |
| Here is an example of the most basic configuration, along with required annotations and sample property access methods: |
mwmitchell
reviewed
Apr 16, 2020
java-sdk/configuration.asciidoc
Outdated
Comment on lines
87
to
108
| Create the schema: | ||
|
|
||
| ```java | ||
| class Runner { | ||
| public static void main(String[] args){ | ||
| ObjectType schema = SchemaGenerator.generate(MyConfig.class); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Generate an instance of the `MyConfig` class: | ||
|
|
||
| ```java | ||
| class Runner { | ||
| public static void main(String[] args){ | ||
| Map<String,Object> data = new java.util.HashMap<>(); | ||
| data.put("id", 100); | ||
| MyConfig config = ModelGenerator.generate(MyConfig.class, data); | ||
| System.out.println("id -> " + config.getId()); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I think this is the only section that needs to be removed. The rest of it is relevant to building configs schemas.
Updating documentation on connector configurations and schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the page /java-sdk/configuration.asciidoc and removes mention of schema methods that are no longer needed. Also removes the "get" prefix from the examples. String getId(); -> String id();