-
-
Notifications
You must be signed in to change notification settings - Fork 158
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix failed specs in Crystal v1.13 (#1909)
* Fix invalid query string for array params * Add spec expectation * Add check for correctness of values returned from array query params * Fix failed specs in Crystal v1.13 ``` Failures: 1) Lucky::CookieJar raises a nicer error for invalid cookie values Failure/Error: expect_raises(Lucky::InvalidCookieValueError, "Cookie value for 'cookie' is invalid") do Expected Lucky::InvalidCookieValueError but nothing was raised Error: # spec/lucky/cookies/cookie_jar_spec.cr:41 ``` Crystal v1.13 accepts space in cookie values as valid. See <crystal-lang/crystal#14455>.
- Loading branch information
Showing
3 changed files
with
38 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters