Replace compiler-specific fallthrough with more general form #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[[fallthrough]] as an attribute was standardized quite a while ago, and gcc (rightfully) doesn't like [[clang::fallthrough]] :)
|
Hi @bluebandit21, thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ attribute [[fallthrough]] was standardized in C++ 17 (see: here )
Currently, all major compilers support it :)
On GCC, trying to compile hash.hpp creates a compiler error by default, as it doesn't know about the clang-specific clang::fallthrough attribute.
Replacing it with the more general standardized form fixes compilation on GCC without affecting Clang builds at all.