Skip to content

Commit

Permalink
Merge pull request #6 from lume/update-lowclass-and-lume-element
Browse files Browse the repository at this point in the history
replace `Observable.ts` with `@lume/eventful` and remove `lowclass`
  • Loading branch information
trusktr authored Sep 29, 2024
2 parents 79c0838 + 4893f2b commit 3f4bc0d
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 187 deletions.
16 changes: 0 additions & 16 deletions dist/Observable.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion dist/Observable.d.ts.map

This file was deleted.

64 changes: 0 additions & 64 deletions dist/Observable.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/Observable.js.map

This file was deleted.

11 changes: 8 additions & 3 deletions dist/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import { Observable } from './Observable.js';
declare const FileScanner_base: (new (...a: any[]) => {
"__#1@#eventMap": Map<string, Set<[Function, any]>> | null;
on(eventName: string, callback: Function, context?: any): void;
off(eventName: string, callback?: Function, context?: any): void;
emit(eventName: string, data?: any): void;
}) & (new (...a: any[]) => object);
/**
* @class FileScanner - Scans files for JSDoc-style comments, outputting usable
* objects representing the found tags.
* @extends Observable
* @extends Eventful
*/
export declare class FileScanner extends Observable {
export declare class FileScanner extends FileScanner_base {
/**
* @method scanFile - Scans a file and triggers the 'comment' for each comment
* that the scanner parsers while scanning the file.
Expand Down
2 changes: 1 addition & 1 deletion dist/index.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
},
"homepage": "https://github.com/trusktr/readem",
"dependencies": {
"@lume/eventful": "^0.3.2",
"army-knife": "^0.2.0",
"async": "^0.9.0",
"at-at": "^1.1.0",
Expand All @@ -53,14 +54,13 @@
"ejs": "^2.2.4",
"highlight.js": "^8.4.0",
"jsdoctypeparser": "^6.1.0",
"lowclass": "^7.0.0",
"lume": "0.0.0-rc.0",
"mkdirp": "^0.5.1",
"rndm": "^1.1.0",
"serve": "^1.4.0"
},
"devDependencies": {
"@lume/cli": "^0.11.0",
"@lume/cli": "^0.13.0",
"@types/mkdirp": "^0.5.2",
"@types/node": "^13.1.8",
"prettier": "3.0.3",
Expand Down
90 changes: 0 additions & 90 deletions src/Observable.ts

This file was deleted.

7 changes: 3 additions & 4 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@ import * as path from 'path'
import walker from 'at-at'
import mkdirp from 'mkdirp'
import jsdocTypeParse from 'jsdoctypeparser'
// TODO, import Observable from a separate package linked by Rush.js
import {Observable} from './Observable.js'
import {Eventful} from '@lume/eventful'

/**
* @class FileScanner - Scans files for JSDoc-style comments, outputting usable
* objects representing the found tags.
* @extends Observable
* @extends Eventful
*/
export class FileScanner extends Observable {
export class FileScanner extends Eventful() {
/**
* @method scanFile - Scans a file and triggers the 'comment' for each comment
* that the scanner parsers while scanning the file.
Expand Down

0 comments on commit 3f4bc0d

Please sign in to comment.