Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter RoleArn for use during CloudFormation compatibility #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rchekaluk
Copy link

When following the instructions to run SAR-Lambda-Janitor via CloudFormation, CloudFormation throws the following error:

Embedded stack arn:aws:cloudformation:REGION:000000000000:stack/SAR-Lambda-Janitor-SARLambdaJanitor-XXXXXXXXXXXX/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee was not successfully created: The following resource(s) failed to create: [CleanRole].

According to the AWS::Serverless::Function documentation, the Role property "is required in AWS CloudFormation but not in AWS SAM. If a role isn't specified, one is created for you with a logical ID of <function-logical-id>Role."

This change adds a new optional parameter RoleArn that can be used to provide the arn of an existing role when using via CloudFormation.

Syntax checked only; it has not been checked in execution.

@theburningmonk
Copy link
Collaborator

hey, looks like the problem is that one of the IAM role was not created (if you can look at the CloudFormation stack hopefully it'll show you more info).

When you're on this screen, did you click the box I acknowledge that this app creates custom IAM roles.?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants