Merge pull request #96 from lumigo-io/fix-eventbridge-bug

fix: no target ids
lumigo-io · May 25, 2020 · adbf458 · adbf458
2 parents 5419b2b + 216e5db
commit adbf458
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/lib/eventbridge.js b/src/lib/eventbridge.js
@@ -40,11 +40,13 @@ const deleteEventBridge = async (eventBridgeName, region, retryOpts, AWS) => {
 					AWS
 				);
 				const targetIDs = targets.map(target => target.targetId);
-				await EventBridge.removeTargets({
-					Ids: targetIDs,
-					Rule: rule.name,
-					EventBusName: eventBridgeName
-				}).promise();
+				if (targetIDs.length > 0) {
+					await EventBridge.removeTargets({
+						Ids: targetIDs,
+						Rule: rule.name,
+						EventBusName: eventBridgeName
+					}).promise();
+				}
 				await EventBridge.deleteRule({
 					Name: rule.name,
 					EventBusName: eventBridgeName