Extract Camera class #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include eclipse-generated files
This also handles errors being thrown from the Client class.
|
LGTM. Would you like me to merge now? As this was submitted as a draft. |
|
Not yet. There is still more fields and methods to extract and document. |
|
It looks like the client is doing a bunch of unnecessary calculations just to get the camera to shake. It'll be great if we could remove all of this auto-generated fluff before pushing this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
Clientclass has over 10,000 lines of code. When trying to debug, find, or add functionality related to the main camera, it becomes extremely tedious.Result
The changes made have slightly reduced clutter in
Client, making it easier to add camera-related features.Additional Information
I've also either thrown or, caught most exceptions in
Clientto make debugging less-confusing.This branch contains all commits made in #2