Video encoder frame #905
Merged
Video encoder frame #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| void H265Parser::parseNal(buf& bs, uint start, std::vector<SliceType>& out) { | ||
| nalUnitType = (bs[start] & 126) >> 1; |
There was a problem hiding this comment.
boundary check would be nice here.
Copy the code to chatgpt w/ the following prompt:
Sanitize the following code snippet:
"
"
alex-luxonis
reviewed
Nov 8, 2023
| numExtraSliceHeaderBits = readUint(bs, bpos2, bpos2 + 3); | ||
| bpos2 += 3; | ||
| pos = (uint)(bpos2 / 8) + (bpos2 % 8 > 0); | ||
| } else if((0 <= nalUnitType && nalUnitType <= 9) || (16 <= nalUnitType && nalUnitType <= 21)) { |
There was a problem hiding this comment.
Getting with GCC 13.1.0:
warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
alex-luxonis
reviewed
Nov 8, 2023
| frameType = utility::getTypesH265(frame.data, true)[0]; | ||
| break; | ||
| } | ||
| switch(frameType) { |
There was a problem hiding this comment.
... and warning: ‘frameType’ may be used uninitialized [-Wmaybe-uninitialized]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an alternative output for the video encoder node. It uses a new message type EncodedFrame that carries more relevant information than ImgFrame.