Message groups #917
Merged
Message groups #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into message_groups
themarpe
requested changes
Nov 3, 2023
moratom
reviewed
Nov 9, 2023
moratom
reviewed
Nov 10, 2023
There was a problem hiding this comment.
The main idea with sync node being able to to send out messages after X attempts even if gets no synced messages was more meant for development&debugging, so you could inspect why sync node can't sync the messages.
Let's remove the successful flag and setDemuxOnlyOnSuccessful and expose this functionality better in Sync node.
moratom
reviewed
Nov 10, 2023
|
Please add an example to |
themarpe
requested changes
Nov 16, 2023
moratom
reviewed
Nov 20, 2023
moratom
requested changes
Nov 20, 2023
themarpe
approved these changes
Nov 28, 2023
moratom
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Sync and MessageDemux nodes with the MessageGroup datatype.