Get connectivity rpc #920
Merged
Get connectivity rpc #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moratom
approved these changes
Nov 10, 2023
| * | ||
| * @returns Vector of connection type | ||
| */ | ||
| std::vector<Connectivity> getConnectivity(); |
There was a problem hiding this comment.
I think something like getAvailableInterfaces() would be better here.
And [Connection?]Interface for the type.
There was a problem hiding this comment.
Note Available usually denotes a subset of all existing. In this case, the function should return "all" device's interfaces that it has. (the "current / what is connectable by" is explorable through device discovery)
Lets just document it accordingly and LGTM
There was a problem hiding this comment.
@themarpe just to clarify, do you mean leave it at getConnectivity() or changing it to getAllInterfaces() ?
There was a problem hiding this comment.
Perhaps getConnectionInterfaces and later on / if need be we can expose available interfaces
jakgra
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Ir brightness control based on normalized intensity, instead of current. * Added IR intensity API. * Update docstring. Point to correct device side commit. * Bump core * Use IR intensity API in cam_test.py * Deprecated ir brightness api, fixed mono_preview_alternate_pro.py example * cam test: use step 0.05 for both dot projector and flood light * Update core * synced depthai-shared with device side * resolve shared issue. * Bump core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.