Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RVC4 support for parsers. #22

Merged
merged 1 commit into from
Aug 19, 2024
Merged

RVC4 support for parsers. #22

merged 1 commit into from
Aug 19, 2024

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Aug 16, 2024

This PR modifies some already present parsers such that they can handle both rvc2 and rvc4.

Updated parsers:

  1. Image Output
  2. Keypoints
  3. MediaPipe Hand Landmarker
  4. MediaPipe Palm Detection
  5. Segmentation
  6. SuperAnimal Landmarker
  7. XFeat

We add dequantize=True to every output tensor (it does not affect rvc2 results). Sometimes also the output shapes must be modified.

@kkeroo kkeroo self-assigned this Aug 16, 2024
@kkeroo kkeroo requested a review from jkbmrz August 16, 2024 07:51
Copy link
Collaborator

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also planning merge a similar fix today for the remaining parsers in #14

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkeroo kkeroo merged commit bee80cb into main Aug 19, 2024
1 check passed
@kkeroo kkeroo deleted the rvc4_support branch August 19, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants