Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor encoder-related code into EncoderComponent #1130

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Refactor encoder-related code into EncoderComponent #1130

wants to merge 27 commits into from

Conversation

geektrove
Copy link
Contributor

Allow users to create multiple encoders for each CameraComponent and StereoComponent

  • Add EncoderComponent
  • Ensure encoder compatible size when creating EncoderComponent
  • Remove encoders from CameraComponent and StereoComponent
  • Remove encoded output from NNComponent

Tested with multiple CameraComponent, StereoComponent, recording and replaying.

@geektrove
Add get_fps method to StereoComponent
0cb3d78
@geektrove
Save colormap_manip as instance variable in StereoComponent
9d2b406
@geektrove
Add EncoderComponent
e736c02
@geektrove
Remove config_encoder methods from CameraComponent
92a4aec
@geektrove
Connect node out to encoder
59a8a29
@geektrove
Remove duplicated _replay assignment
b6f5356
@geektrove
Rename _encoder with node
528d5fd
@geektrove
Fix style
87a62a9
@geektrove
Ensure encoder compatible size when creating EncoderComponent
fd1963a
@geektrove
Implement component outputs for EncoderComponent
0a04473
@geektrove
Remove encoded output from CameraComponent
9f0a963
@geektrove
Remove encoded output from NNComponent
2897c8b
@geektrove
Remove encoder from StereoComponent
875aaad
@geektrove
Remove unused device and pipeline from instance variables
0c40188
@geektrove
Add EncoderComponent to components.__init__
15a2185
@geektrove
Remove encode parameter from create_camera and create_stereo
3f46e41
@geektrove
Add create_encoder method
3e85779
@geektrove
Set compatible ISP and video size only for ColorCamera
44b1f96
@geektrove
Add ensure_encoder_compatible_size to StereoComponent
53966b6
@geektrove
Fix OakCamera method ordering
e1d8a35
@geektrove
Remove encode from all_cameras, use camera method instead
a4b227f
@geektrove
Remove unused imports
3a5f3bf
@geektrove
Handle replay input (XLinkIn)
f957de0
@geektrove
Format EncoderComponent code
ea2b377
@geektrove
Ensure NV12 format when using replay
c5923b5
@geektrove geektrove requested a review from Erol444 October 22, 2023 10:17
@Erol444
Copy link
Member

Erol444 commented Oct 22, 2023

@OpeningNew also update all examples that use videoEnc funcitonality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erol444 Erol444 Awaiting requested review from Erol444

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geektrove @Erol444