Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log_matrix #209

Merged
merged 7 commits into from
Nov 26, 2024
Merged

feat: log_matrix #209

merged 7 commits into from
Nov 26, 2024

Conversation

JSabadin
Copy link
Contributor

Add an option to log a matrix as an artifact.

@JSabadin JSabadin requested a review from a team as a code owner November 22, 2024 05:12
@JSabadin JSabadin requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team November 22, 2024 05:12
@github-actions github-actions bot added enhancement New feature or request tracker Changes affecting luxonis_ml.tracker subpackage labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (6bcbb11) to head (bead880).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   92.33%   92.30%   -0.03%     
==========================================
  Files          79       79              
  Lines        4161     4275     +114     
==========================================
+ Hits         3842     3946     +104     
- Misses        319      329      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a small comment

luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments

luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
luxonis_ml/tracker/tracker.py Outdated Show resolved Hide resolved
@JSabadin JSabadin merged commit abf2f9a into main Nov 26, 2024
12 checks passed
@JSabadin JSabadin deleted the feat/log_matrix branch November 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracker Changes affecting luxonis_ml.tracker subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants