-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLFlow Upload Fix #10
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Test Results 6 files 6 suites 36m 39s ⏱️ Results for commit 0abec0e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I did a quick manual test. It appears a couple workflows are failing though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on my end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fixed incorrect class property call * fixed exporter uploading * uploadCheckpoint uploads on every checkpoint epoch * fix temp files names * updated callback readme * pre-commit run
ExportOnTrainEnd
callback's ability to upload to mlflow (also some fixes inExporter
related to this)UploadCheckpoint
callback (previouslyUploadCheckpointOnTrainEnd
) so it now uploads currently best checkpoint (based on validation loss) after every validation interval. This way we have some intermediate checkpoint in case training crashes before it is finished.