Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call tracker.close() #119

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: call tracker.close() #119

merged 2 commits into from
Nov 8, 2024

Conversation

JSabadin
Copy link
Contributor

@JSabadin JSabadin commented Oct 30, 2024

Call close() on Tracker After Training Completion

Summary

This update ensures close() is executed on the tracker after training finishes, aligning with recent changes in luxonis-ml (This PR)

@JSabadin JSabadin requested a review from a team as a code owner October 30, 2024 08:24
@JSabadin JSabadin requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team October 30, 2024 08:24
@github-actions github-actions bot added the fix Fixing a bug label Oct 30, 2024
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to make a new release of luxonis-ml before we merge

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (631b905) to head (78d2e81).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   96.31%   95.79%   -0.53%     
==========================================
  Files         147      159      +12     
  Lines        6304     6902     +598     
==========================================
+ Hits         6072     6612     +540     
- Misses        232      290      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klemen1999 klemen1999 merged commit 509446b into main Nov 8, 2024
8 of 9 checks passed
@klemen1999 klemen1999 deleted the fix/mlflow-crash branch November 8, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants