fix: ddp bug #145
Open
fix: ddp bug #145
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSabadin
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
klemen1999
reviewed
Dec 16, 2024
Yes, if the output metrics are stored on the device's CPU |
|
Lets test this out and include the fixes for others as well under this PR in that case |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 96.31% 95.01% -1.31%
==========================================
Files 147 170 +23
Lines 6304 7517 +1213
==========================================
+ Hits 6072 7142 +1070
- Misses 232 375 +143 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates the metric computation step to ensure that all returned metrics (
mapand related values) are moved to the GPU device before logging. Without this change, calls topl.logwould trigger runtime errors by attempting distributed reductions (all_reduce) on CPU tensors under thencclbackend in multi-GPU training environments.