feat:grad-clip #146
Merged
feat:grad-clip #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSabadin
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
github-actions
bot
added
documentation
klemen1999
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 96.31% 95.01% -1.31%
==========================================
Files 147 170 +23
Lines 6304 7516 +1212
==========================================
+ Hits 6072 7141 +1069
- Misses 232 375 +143 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Gradient Clipping Options to Trainer Config
This PR introduces two new options in the Trainer configuration for gradient clipping:
gradient_clip_val: Allows users to set a value for gradient clipping (default:Nonefor no clipping).gradient_clip_algorithm: Specifies the clipping algorithm, either"norm"(clip by norm) or"value"(clip element-wise, default:None).