-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Loaders Support #27
Conversation
Test Results 6 files 6 suites 38m 16s ⏱️ For more details on these failures and errors, see this check. Results for commit 49aab2b. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement, thanks!
@@ -23,7 +25,8 @@ | |||
HEAD_NAMES = [head_name for head_name in ImplementedHeads.__members__] | |||
|
|||
|
|||
class TestArchiver: | |||
@pytest.mark.skip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we skip this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NN Archive in the latest dev of luxonis-ml is not compatible with the tests for now (we need to figure out the yolov8 keypoint outputs in the archive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1/ Does this affect any of our current online datasets?
2/ Have we tested the kpts training?
Otherwise looks good, thanks!
sampler = torch_data.WeightedRandomSampler(weights, num_samples) | ||
|
||
self.pytorch_loaders = { | ||
view: torch_data.DataLoader( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if self.loaders[view] does not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will always exist
No, this shouldn't change anything regarding the underlying datasets
Yes |
@kozlov721 What is the correct way of providing |
* support for custom loaders and datasets * updated configs * custom loaders in inspect command * updated inspect for multi-task labels * removed custom loader from test config * deleted comment * deleted comment * removed custom dataset * removed comment * skipping archiver test untill fixed in luxonis-ml * [Automated] Updated coverage badge --------- Co-authored-by: GitHub Actions <[email protected]>
Added support for using custom loaders.
Example
source.py
Breaking Config Changes
dataset
section renamed toloader
. Custom loader can be referenced by its name in theLOADERS
registry. The default loader isLuxonisLoaderTorch
. Former keys of thedataset
field now go underparams
field in theloader
.