Add workflow for e2e tests #2
Conversation
.github/workflows/e2e.yml
Outdated
| push: | ||
| branches: [ main ] | ||
| branches: [ main, feat/workflow-for-e2e ] |
There was a problem hiding this comment.
Question: as I understand it, we only want to run these tests after a deploy? This already happens on push to the main branch, so probably we can remove the push directive here.
| @@ -1,33 +1,43 @@ | |||
| name: E2E tests | |||
| on: | |||
| workflow_call: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Nitpick: I think we only need workflow_call to be able to call this workflow from the deployment one. workflow_dispatch is only necessary if we want to trigger it manually.
Thought: We can also run it on a schedule (e.g. daily) by using the schedule directive. Perhaps in that case we should send the results to Slack somehow? Or report them somewhere else that we're aware?
There was a problem hiding this comment.
Schedule and alert on slack is good idea.
I've added workflow_dispatch just in case. But if you want I can remove it
There was a problem hiding this comment.
No, it's fine that it's there. Perhaps we want to run the tests manually at some point. 🙂
KrijnL
force-pushed
the
feat/workflow-for-e2e
branch
4 times, most recently
from
a64d131 to
71b88f6
Compare
Test Summary - Run #30
🎉 All tests passed! |
KrijnL
force-pushed
the
feat/workflow-for-e2e
branch
4 times, most recently
from
87874dc to
e420fb2
Compare
Test Summary - Run #34
🎉 All tests passed! |
KrijnL
force-pushed
the
feat/workflow-for-e2e
branch
from
e420fb2 to
e0b206a
Compare
Test Summary - Run #35
🎉 All tests passed! |
KrijnL
force-pushed
the
feat/workflow-for-e2e
branch
2 times, most recently
from
8da035c to
5063ca5
Compare
Test Summary - Run #37
🎉 All tests passed! |
KrijnL
force-pushed
the
feat/workflow-for-e2e
branch
from
5063ca5 to
dc8ff85
Compare
No description provided.