bugfix: fix interface sort order #171
Merged
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
Nov 21, 2024
| favorWithValue := func(a, b string) bool { | ||
| if a == "" && b == "" { | ||
| return false | ||
| } |
There was a problem hiding this comment.
I added a line break here.
Do you have some rules I can align to, about when and where you would like to have line breaks?
My feeling says: either I omit the line breaks, since this is a very short function, where all the pieces belong together (no real paragraphs in the sense that they touch different things) or I would add an other new line also after the second if block (before the return).
There was a problem hiding this comment.
Essentially line break after every block is the coding style we've been going with.
Signed-off-by: Lucas Bremgartner <[email protected]>
breml
force-pushed
the
fix-flaky-network-test
branch
from
0566f99 to
09a4ecf
Compare
stgraber
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the flake acceptance tests where ipv4 address is not set, e.g. https://github.com/lxc/terraform-provider-incus/actions/runs/11933941679/job/33262025197#step:8:242