Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace argparse with click and pyfiglet with const 🪥 #35

Merged
merged 2 commits into from
Jan 8, 2024
Merged

refactor: replace argparse with click and pyfiglet with const 🪥 #35

merged 2 commits into from
Jan 8, 2024

Conversation

KarelZe
Copy link
Collaborator

@KarelZe KarelZe commented Jan 7, 2024 •
edited by lxndrblz
Loading

  • Replaces argparse with click
  • Removes pyfiglet with const for easier packaging

@KarelZe KarelZe added the good first issue Good for newcomers label Jan 7, 2024
@KarelZe KarelZe self-assigned this Jan 7, 2024
@KarelZe KarelZe added enhancement New feature or request and removed good first issue Good for newcomers labels Jan 7, 2024
@KarelZe KarelZe requested a review from lxndrblz January 7, 2024 19:11
lxndrblz
lxndrblz approved these changes Jan 8, 2024
View reviewed changes
Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarelZe LGTM. Thanks for your hard work!

@lxndrblz lxndrblz merged commit 0ca01cc into main Jan 8, 2024
1 check passed
@KarelZe KarelZe deleted the pyfiglet branch January 8, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxndrblz lxndrblz lxndrblz approved these changes

Assignees

@KarelZe KarelZe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarelZe @lxndrblz