Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
123920: codeowners: add upgrade-prs team to pkg/upgrade r=RaduBerinde a=celiala

Can be merged after `upgrade-prs` team is created:
- https://github.com/cockroachlabs/crl-infrastructure/pull/1903

Epic: None
Release note: None

Co-authored-by: Celia La <[email protected]>
  • Loading branch information
craig[bot] and celiala committed Jun 9, 2024
2 parents c7f37e8 + eda91d1 commit bd4c5fd
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
/pkg/ccl/jwtauthccl/ @cockroachdb/cloud-identity
#!/pkg/ccl/kvccl/ @cockroachdb/kv-noreview
/pkg/ccl/kvccl/kvtenantccl/ @cockroachdb/server-prs
#!/pkg/ccl/upgradeccl/ @cockroachdb/release-eng
#!/pkg/ccl/upgradeccl/ @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs
#!/pkg/ccl/logictestccl/ @cockroachdb/sql-queries-noreview
#!/pkg/ccl/sqlitelogictestccl/ @cockroachdb/sql-queries-noreview
/pkg/ccl/multiregionccl/ @cockroachdb/sql-foundations
Expand Down Expand Up @@ -515,7 +515,7 @@
/pkg/keysbase/ @cockroachdb/kv-prs
# Don't ping KV on updates to reserved descriptor IDs and such.
#!/pkg/keys/constants.go @cockroachdb/kv-prs-noreview
/pkg/upgrade/ @cockroachdb/release-eng
/pkg/upgrade/ @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs
/pkg/keyvisualizer/ @cockroachdb/obs-prs
/pkg/multitenant/ @cockroachdb/server-prs
/pkg/release/ @cockroachdb/dev-inf
Expand Down
3 changes: 3 additions & 0 deletions TEAMS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,8 @@ cockroachdb/migrations:
label: T-migrations
triage_column_id: 18330909
cockroachdb/release-eng:
aliases:
cockroachdb/release-eng-prs: other
cockroachdb/upgrade-prs: other
label: T-release
triage_column_id: 9149730
1 change: 1 addition & 0 deletions pkg/cmd/roachtest/registry/owners.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const (
OwnerServer Owner = `server` // not currently staffed
OwnerSQLFoundations Owner = `sql-foundations`
OwnerMigrations Owner = `migrations`
OwnerReleaseEng Owner = `release-eng`
OwnerSQLQueries Owner = `sql-queries`
OwnerStorage Owner = `storage`
OwnerTestEng Owner = `test-eng`
Expand Down
1 change: 1 addition & 0 deletions pkg/cmd/roachtest/tests/acceptance.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func registerAcceptance(r registry.Registry) {
nativeLibs []string
incompatibleClouds []string // Already assumes AWS is incompatible.
}{
registry.OwnerReleaseEng: {},
registry.OwnerKV: {
{name: "decommission-self", fn: runDecommissionSelf},
{name: "event-log", fn: runEventLog},
Expand Down
3 changes: 3 additions & 0 deletions pkg/internal/team/TEAMS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,8 @@ cockroachdb/migrations:
label: T-migrations
triage_column_id: 18330909
cockroachdb/release-eng:
aliases:
cockroachdb/release-eng-prs: other
cockroachdb/upgrade-prs: other
label: T-release
triage_column_id: 9149730

0 comments on commit bd4c5fd

Please sign in to comment.