Merge cockroachdb#123321 cockroachdb#123393 cockroachdb#123394 cockro…

…achdb#123400

123321: roachtest: set 23.1.8 as MinSupportedVersion for sql-stats/mixed-version  r=xinhaoz a=xinhaoz

There is a bug in the sql stats api prior to 23.1.8, where
passing a requested start time of 0 or nil results in a
nil pointer dereference.

Setting this min supported version  also resolves some mixed
version authentication limitations.

Epic: none
Fixes: cockroachdb#123278

Release note: None

123393: github: adjust stale workflow r=yuzefovich a=yuzefovich

This commit adjusts the stale workflow so that it only closes stale test failures and sentry issues. Previously, it would close all issues with no activity in the last 18 months (modulo some exempted labels), but I don't think it's helpful to close issues filed by humans in this way - we might still want to track a particular bug or a feature in order to gauge the urgency. Closing stale (no activity in 12 months) test failures (as defined by having `C-test-failure` label) and sentry issues seems like a good idea though.

This commit also removes a few fields that are related to stale PRs since we don't do anything for them (because we use very large "inactivity" window).

Epic: None

Release note: None

123394: streamclient: allow running on remote execution r=rail a=rickystewart

I don't know how long this has worked, but it works now.

Epic: CRDB-8308
Release note: None

123400: roachtest: move generate-fixtures roachtest to test-eng ownership r=renatolabs a=rickystewart

Epic: none
Release note: None

Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>

.github/workflows/stale.yml

@@ -1,4 +1,4 @@
-name: Mark stale issues and pull requests
+name: Close stale test failures and sentry issues
 
 on:
   schedule:
@@ -18,17 +18,14 @@ jobs:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
         stale-issue-message: |
            We have marked this issue as stale because it has been inactive for
-           18 months. If this issue is still relevant, removing the stale label
+           12 months. If this issue is still relevant, removing the stale label
            or adding a comment will keep it active. Otherwise, we'll close it in
-           10 days to keep the issue queue tidy. Thank you for your contribution
-           to CockroachDB!
-        stale-pr-message: 'Stale pull request message'
+           10 days to keep the issue queue tidy.
         stale-issue-label: 'no-issue-activity'
-        stale-pr-label: 'no-pr-activity'
         close-issue-label: 'X-stale'
-        close-pr-label: 'X-stale'
         # Disable this for PR's, by setting a very high bar
         days-before-pr-stale: 99999
-        days-before-issue-stale: 540
+        days-before-issue-stale: 366
         days-before-close: 10
+        any-of-issue-labels: 'C-test-failure,O-sentry'
         exempt-issue-labels: 'release-blocker,X-anchored-telemetry,X-nostale'

pkg/ccl/streamingccl/streamclient/BUILD.bazel

@@ -57,7 +57,6 @@ go_test(
         "span_config_stream_client_test.go",
     ],
     embed = [":streamclient"],
-    tags = ["no-remote-exec"],
     deps = [
         "//pkg/base",
         "//pkg/ccl",

pkg/cmd/roachtest/tests/fixtures.go

@@ -67,7 +67,7 @@ func registerFixtures(r registry.Registry) {
 		Timeout:          30 * time.Minute,
 		CompatibleClouds: registry.Clouds(spec.GCE, spec.Local),
 		Suites:           registry.Suites(registry.Fixtures),
-		Owner:            registry.OwnerDevInf,
+		Owner:            registry.OwnerTestEng,
 		Cluster:          r.MakeClusterSpec(4),
 		Run:              runFixtures,
 	})

pkg/cmd/roachtest/tests/mixed_version_sql_stats.go

@@ -54,7 +54,8 @@ func registerSqlStatsMixedVersion(r registry.Registry) {
 func runSQLStatsMixedVersion(ctx context.Context, t test.Test, c cluster.Cluster) {
 	roachNodes := c.Range(1, c.Spec().NodeCount-1)
 	workloadNode := c.Node(c.Spec().NodeCount)
-	mvt := mixedversion.NewTest(ctx, t, t.L(), c, roachNodes)
+	mvt := mixedversion.NewTest(ctx, t, t.L(), c,
+		roachNodes, mixedversion.MinimumSupportedVersion("v23.1.8"))
 	flushInterval := 2 * time.Minute
 
 	initWorkload := roachtestutil.NewCommand("./cockroach workload init tpcc").
@@ -163,7 +164,7 @@ func getCombinedStatementStatsURL(
 ) string {
 	searchParams := fmt.Sprintf("?fetch_mode.stats_type=%d&start=%d&end=%d&limit=10",
 		statsType, requestedRange[0].Unix(), requestedRange[1].Unix())
-	return `http://` + adminUIAddr + `/_status/combinedstmts` + searchParams
+	return `https://` + adminUIAddr + `/_status/combinedstmts` + searchParams
 }
 
 // timeRange is a pair of time.Time values.