Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Set workflow layout title as either route or workflow display names #3174

Merged
merged 2 commits into from
Nov 18, 2024
Merged

frontend: Set workflow layout title as either route or workflow display names #3174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7321fa1
Set workflow layout title as either route or workflow display names
septum Nov 13, 2024
873e618
Merge main branch into wl-display-name
septum Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/packages/core/src/AppProvider/index.tsx
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the block above required?, or may it need adjustment?

const heading = route.displayName
  ? `${workflow.displayName}: ${route.displayName}`
  : workflow.displayName;

Copy link
Contributor Author

@septum septum Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed as the fallback if useWorkflowLayout is not enabled.

Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ const ClutchApp = ({

const workflowLayoutProps: LayoutProps = {
workflow,
title: heading,
title: route.displayName || workflow.displayName,
subtitle: route.description,
variant:
route.layoutProps?.variant === null ||
Expand Down
Loading