convert periods in tag values to underscore (#44)

lyft · Sep 10, 2018 · acc84a6 · acc84a6
1 parent 4b10ad9
commit acc84a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/tags.go b/tags.go
@@ -14,7 +14,7 @@ const (
 )
 
 // illegalTagValueChars are loosely set to ensure we don't have statsd parse errors.
-var illegalTagValueChars = regexp.MustCompile(`[:|]`)
+var illegalTagValueChars = regexp.MustCompile(`[:|.]`)
 
 type tagPair struct {
 	dimension string

diff --git a/tags_test.go b/tags_test.go
@@ -27,3 +27,11 @@ func TestSerializeIllegalTags(t *testing.T) {
 		t.Errorf("Serialized output (%s) didn't match expected output", serialized)
 	}
 }
+
+func TestSerializeTagValuePeriod(t *testing.T) {
+	tags := map[string]string{"foo": "blah.blah", "q": "p"}
+	serialized := serializeTags(tags)
+	if serialized != ".__foo=blah_blah.__q=p" {
+		t.Errorf("Serialized output (%s) didn't match expected output", serialized)
+	}
+}