Fix query ui history redirect #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
force-pushed
the
fix_162
branch
3 times, most recently
from
ae80dfe
to
49dced5
Compare
| String routingGroup = routingGroupSelector.findRoutingGroup(request); | ||
| String user = Optional.ofNullable(request.getHeader(USER_HEADER)) | ||
| .orElse(request.getHeader(ALTERNATE_USER_HEADER)); | ||
| if (!Strings.isNullOrEmpty(routingGroup)) { | ||
| // This falls back on adhoc backend if there are no cluster found for the routing group. | ||
| backendAddress = routingManager.provideBackendForRoutingGroup(routingGroup, user); | ||
| return routingManager.provideBackendForRoutingGroup(routingGroup, user); |
There was a problem hiding this comment.
please dont return from here. Below lines are skipped. without this, subsequent calls would require a broadcast to all backends for query id lookup.
// set target backend so that we could save queryId to backend mapping later.
((MultiReadHttpServletRequest) request).addHeader(PROXY_TARGET_HEADER, backendAddress);
would be nice if you could add a test case validating the presence of this header in the response.
There was a problem hiding this comment.
Hi @puneetjaiswal thanks for taking a look. The above return is within the orElseGet lambda for the backendAddress assignment. Effectively, L137 doesn't get skipped. I'll add a test.
|
@regadas heads up, this fails |
|
@Pluies yup indeed it was faulty, somehow I missed that. Thanks for pointing that out! |
|
Hi, it would be great if this PR gets merged ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This addresses the issue in #162 here
/ui/query?<QUERYID>is redirected by default to adhoc