Fix locking with unsaved changes bug #1340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkrlli Thank you very much for actually doing it, I couldn't find time to fix my PR :) |
MaicolBen
reviewed
Sep 12, 2019
| # At this point restore the attributes so we can obtain the lock | ||
| # otherwise an exception is thrown while trying to obtain the lock | ||
| # with unsaved data on the resource. | ||
| unless const_defined?('Mongoid') do |
added 2 commits
September 12, 2019 15:08
MaicolBen
reviewed
Sep 19, 2019
| # At this point restore the attributes so we can obtain the lock | ||
| # otherwise an exception is thrown while trying to obtain the lock | ||
| # with unsaved data on the resource. | ||
| @resource.restore_attributes unless const_defined?('Mongoid') |
There was a problem hiding this comment.
It's breaking the specs, I think you have to use defined? instead, const_defined? is with Module.const_defined?("something")
|
@MaicolBen Made the change, sorry it took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MaicolBen @Tiltorito
attr_encryptedandlockboxgems, since they re-encrypt data on validation.valid?leaves unsaved changes, which throws an error when calling@resource.with_lock