Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button component #621

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

susannalandstrom
Copy link
Contributor

@susannalandstrom susannalandstrom commented Oct 11, 2023

Background

We have decided to make changes to Lyyti Design System so that we utilise more things straight from MUI. First step is the Button component, which is now more similar to MUI's button, still utilising our brand and having some changes we find better suitable for us.

  • The custom colors for Success, Info, Warning and Error are removed and we use these colors from MUI's default theme.
  • Outlined buttons have white background and therefore also custom hover styles for each colour variant.
  • Changes to button sizes

⚠️ BREAKING CHANGES ⚠️

  • Button does not have chunky property anymore, instead three sizes (large, medium, small)
  • Alignment of page headers and buttons needs to be checked.
  • danger color variant has been renamed to error
  • disabledBg property has been removed from ColorStateOption interface -> Theme does not have primaryStates.disabledBg or lightStates.disabledBg prop anymore and these colours need to be replaces with some other colours in portal.

Which version should I bump?

@susannalandstrom susannalandstrom requested a review from a team as a code owner October 11, 2023 13:07
Copy link
Contributor

@mikael-jarvinen mikael-jarvinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mikael-jarvinen
Copy link
Contributor

Which version should I bump?

Sounds like a major update.

@susannalandstrom susannalandstrom merged commit b62eb38 into lyytioy:next Oct 12, 2023
1 check passed
@susannalandstrom susannalandstrom mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants