Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for music videos #210

Merged
merged 6 commits into from
Aug 11, 2017

Conversation

jingai
Copy link
Collaborator

@jingai jingai commented Aug 10, 2017

Allow the user to play/shuffle music videos like the other media types. Support has been added for shuffling music videos, shuffling music videos by genre, and playing specific music videos.

Allowing the user to request music videos by a specific artist presented a little more difficulty, so I raised Issue #212 for that.

The new slot MUSICVIDEOS was required to implement this, which has already been added to the web slot generator and is included in the Python generator in this PR.

Requires changes to Kodi-Voice found in version 0.9.7.

Needs German translations

Addresses Issue #118.

@jingai jingai changed the title Add full support for music videos Add better support for music videos Aug 10, 2017
@jingai
Copy link
Collaborator Author

jingai commented Aug 10, 2017

Ping @mcl22 and @ausweider for German translations :)

@mcl22
Copy link

mcl22 commented Aug 11, 2017

Here you are:

could_not_find_musicvideo: "Konnte kein Musikvideo mit dem Namen {{ heard_musicvideo }} finden"
playing_musicvideo_card: "Spiele Musikvideo"
shuffling_musicvideos: "Spiele zufällige Musikvideos"
shuffling_musicvideos_genre: "Spiele zufällige {{ genre }} Musikvideos"

WatchMusicVideo zeige (/das) Musikvideo {MusicVideo}
ShuffleMusicVideos zeige (/zufällige/alle) (/{MusicVideoGenre}) Musikvideos

@jingai
Copy link
Collaborator Author

jingai commented Aug 11, 2017

Thanks again @mcl22!

@jingai jingai merged commit 700ebc9 into m0ngr31:master Aug 11, 2017
@jingai jingai deleted the play-watch-musicvideo branch August 11, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants