Proposed fix for gas resistance reading #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lbuque <[email protected]>
There is a report in the M5Stack community forum that ENVPro unit fails to report gas resistance. Apparently the returned number alwas is 0.0. So I looked into the source code and it looks like there might be a copy paste error here. Please note: I do not have the ENVPro unit myself so I cannot test this. It's just a hunch that this might be the issue.
|
wrong source branch - too many not needed commits - sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a report in the M5Stack community forum that ENVPro unit fails to report gas resistance. Apparently the returned number always is 0.0. So I looked into the source code and it looks like there might be a copy paste error here.
Please note: I do not have the ENVPro unit myself so I cannot test this. It's just a hunch that this might be the issue.