Skip to content
This repository has been archived by the owner on Jan 23, 2022. It is now read-only.

Migration to the Bootstrap 3. #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moacir-selinger
Copy link

Hello, as we had talked, I started to migrate the template to Bootstrap 3, however, identified that the template is just the shell, which is listed documentation is all fitted with JS. I was afraid to move and mess something up, so I'm sending the part that made ​​the migrated template. If you can adjust the other hand, would be cool. I'm waiting.

@m7r
Copy link
Owner

m7r commented Oct 28, 2014

Well, your pull request is not based on the latest template. It doesn't work as is.

@moacir-selinger
Copy link
Author

Sorry friend, inexperience with github ... I downloaded the current version and am reapplying my changes, I will resent today updated. Thank you!

@moacir-selinger
Copy link
Author

Hello, I believe it is all right now. Remembering that just migrated to index.tmpl, the part where you open the pages, as I understand it, does not use a template, riding all via JS. I was afraid to change this part, then count on you to do it. Thank you!

@moacir-selinger
Copy link
Author

Hello, I wonder if you will accept my PR and adjust the remaining to the migration of the layout to bootstrap 3? So I can use your plugin, you need to be using version 3 of the bootstrap. If not accepted, I ask your permission to copy your project and try to create a new set on needs I need. Would be great to keep her, I'm waiting. Hugs!

@m7r
Copy link
Owner

m7r commented Nov 13, 2014

I will look into this. Currently busy on main work.

@moacir-selinger
Copy link
Author

Sorry :) I am in making the decision on the use of their wonderful tool process, but depending on the Bootstrap 3 ~ to use it. I would love to help you improve yours if you want, I can try to wiggle the part that generates the docs and only give you ~ and then ... What do you think?

@bjendyk
Copy link

bjendyk commented Dec 15, 2014

@m7r, is there any chance of accepting the merge request anytime soon? I'm sure I'm not the only one anxious to have BS3-based ngdocs :)

@m7r
Copy link
Owner

m7r commented Dec 23, 2014

That's a really nice start but it breaks the visual search feedback.

For the next version I want to switch to dgeni (successor of ngdocs) for doc generation. That mean templates for everything. It's then much easier for everyone to personalize the docs pages.

Unfortunately that means a rewrite from ground up with (some) breaking changes.

@rainboxx
Copy link

So this PR is dead and should be rejected? Do you already have some actual plans for switching to dgeni?

@m7r m7r force-pushed the master branch 3 times, most recently from 876f1c4 to b549a54 Compare June 29, 2015 10:17
@marlonmleite
Copy link

Really update for Bootstrap 3 is important.
We have components in our company documentation almost all broken by visually not support Bootstrap 3.
Soon we will have Bootstrap 4.
I need to know if this migration to version 3 of the Bootstrap will it take?
Because otherwise we will try to migrate the project internally or using another tool.

@getuliojr
Copy link

Will it ever be migrated to bootstrap 3 ????

@m7r
Copy link
Owner

m7r commented Dec 2, 2015

Yes and no. I don't think a doc tool should be tight to css framework.
The next version will have the possibilities to customize every aspect of the templates.
If the default is based on Bootstrap 3 or 4 will tell the time.

@getuliojr
Copy link

To follow a pattern is just a matter to make it easy to maintain and develop.

Right now the template used is not even responsive. Since it is based on angular how about modify it for angular material design library.

I could help if you want. Also noticed that it is not using dgeni latest features, some methods are very different like function and method (dgeni).

What you think?

@derekwlms
Copy link

Any updates on this? Just looking for basic BS 3.3.7 support (so we don't have to go outside ngdocs for our BS-3-dependent @examples).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants