Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: query item text props #325

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: query item text props #325

wants to merge 5 commits into from

Conversation

jared-dickman
Copy link
Collaborator

BREAKING CHANGE

Summary

  • align QueryItem.Text props with Typography (change text prop to children)
  • add type prop to QueryItem.Text

tibuurcio
tibuurcio reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we assign a default value for type do we make this not being a breaking change? Maybe worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibuurcio tibuurcio tibuurcio left review comments

@ZoeAstra ZoeAstra Awaiting requested review from ZoeAstra

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jared-dickman @tibuurcio @Seebiscuit