Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popupMatchSelectWidth should default to false #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajenkins-mparticle
Copy link
Contributor

@ajenkins-mparticle ajenkins-mparticle commented Nov 29, 2024

Summary

  • I posit that popupMatchSelectWidth={false} is the better default for Select. I was recently working in an area and it was hidden to me (and I almost shipped a bug) that a certain select items were being truncated.
  • This does not prevent the user from overwriting the supplied value, it's just a better default (imo)

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://mParticle.github.io/aquarium/pr-preview/pr-507/
on branch gh-pages at 2024-11-29 14:40 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant