Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Other Deprecated Methods #21

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

Replace deprecated getVersion

Copy link
Contributor

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 3bb84c0 into master Mar 29, 2022
@BrandonStalnaker BrandonStalnaker deleted the fix-Remove-Other-Deprecated-Methods branch March 29, 2022 14:40
@g4r37h
Copy link

g4r37h commented Jun 23, 2023

This commit should be reverted. It's roDeviceInfo.getVersion that is deprecated, not roAppInfo. You are now returning OS version in places you are meant to be returning channel version. Issue opened at #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants