implement #436

mProjectsCode · Nov 5, 2024 · f5b0049 · f5b0049
1 parent 94e5083
commit f5b0049
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/exampleVault/Buttons/Button Example.md b/exampleVault/Buttons/Button Example.md
@@ -18,11 +18,11 @@ With a custom class and a CSS snippet we can change the button to be green.
 
 ```meta-bind-button
 style: primary
-label: Open Meta Bind FAQ
+label: Open Meta Bind Playground
 class: green-button
 action:
   type: command
-  command: obsidian-meta-bind-plugin:open-faq
+  command: obsidian-meta-bind-plugin:open-playground
 ```
 
 And custom JS buttons as well

diff --git a/packages/core/src/config/ButtonConfigValidators.ts b/packages/core/src/config/ButtonConfigValidators.ts
@@ -165,7 +165,7 @@ export const V_InsertIntoNoteButtonAction = schemaForType<InsertIntoNoteButtonAc
 	}),
 );
 
-export const V_InlineJsButtonAction = schemaForType<InlineJSButtonAction>()(
+export const V_InlineJSButtonAction = schemaForType<InlineJSButtonAction>()(
 	z.object({
 		type: z.literal(ButtonActionType.INLINE_JS),
 		code: stringValidator('inlineJS', 'code', 'code string to run'),
@@ -186,7 +186,7 @@ export const V_ButtonAction = schemaForType<ButtonAction>()(
 		V_ReplaceSelfButtonAction,
 		V_RegexpReplaceInNoteButtonAction,
 		V_InsertIntoNoteButtonAction,
-		V_InlineJsButtonAction,
+		V_InlineJSButtonAction,
 	]),
 );
 

diff --git a/packages/core/src/fields/button/actions/OpenButtonActionConfig.ts b/packages/core/src/fields/button/actions/OpenButtonActionConfig.ts
@@ -4,7 +4,7 @@ import type {
 	ButtonContext,
 	OpenButtonAction,
 } from 'packages/core/src/config/ButtonConfig';
-import { ButtonActionType } from 'packages/core/src/config/ButtonConfig';
+import { ButtonActionType, ButtonClickType } from 'packages/core/src/config/ButtonConfig';
 import { AbstractButtonActionConfig } from 'packages/core/src/fields/button/AbstractButtonActionConfig';
 import type { IPlugin } from 'packages/core/src/IPlugin';
 import { MDLinkParser } from 'packages/core/src/parsers/MarkdownLinkParser';
@@ -19,9 +19,10 @@ export class OpenButtonActionConfig extends AbstractButtonActionConfig<OpenButto
 		action: OpenButtonAction,
 		filePath: string,
 		_context: ButtonContext,
-		_click: ButtonClickContext,
+		click: ButtonClickContext,
 	): Promise<void> {
-		MDLinkParser.parseLinkOrUrl(action.link).open(this.plugin, filePath, action.newTab ?? false);
+		const newTab = click.type === ButtonClickType.MIDDLE || click.ctrlKey || (action.newTab ?? false);
+		MDLinkParser.parseLinkOrUrl(action.link).open(this.plugin, filePath, newTab);
 	}
 
 	create(): Required<OpenButtonAction> {