Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindgen, use libc for symbols available in it and filter the symbols in the generated bindings #20

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Update bindgen, use libc for symbols available in it and filter the symbols in the generated bindings #20

merged 3 commits into from
Nov 17, 2023

Conversation

hjmallon
Copy link
Contributor

There are three commits in here

  1. Updates bindgen, this means that size_t -> usize, so change some types
  2. Update some bindings to use libc types rather than auto generated types (since we already have libc)
  3. Update build.rs to filter which symbols are available in the bindings

mach-kernel
mach-kernel approved these changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@mach-kernel mach-kernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Many thanks! 😸

xpc-sys/build.rs Show resolved Hide resolved
@hjmallon
Copy link
Contributor Author

Thanks for the speedy review, it says I need write access to merge so I guess I will have to leave it up to you.

@mach-kernel mach-kernel merged commit 33b8bed into mach-kernel:master Nov 17, 2023
1 check passed
@mach-kernel
Copy link
Owner

Merged + released to crates.io with a patch level bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mach-kernel mach-kernel mach-kernel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjmallon @mach-kernel