Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-lsp-server: new port #11601

Merged
merged 4 commits into from
Jul 22, 2021
Merged

python-lsp-server: new port #11601

merged 4 commits into from
Jul 22, 2021

Conversation

gpanders
Copy link
Contributor

Description

The py-language-server port is deprecated as the upstream project is
unmaintained. This port provides the maintained, community fork.

See palantir/python-language-server#935.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.7 19H1217 x86_64
Xcode 12.4 12D4e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@reneeotten for port py-language-server, py-python-jsonrpc-server.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: submission labels Jul 15, 2021
@gpanders
Copy link
Contributor Author

@reneeotten Would you like to be added as a maintainer to the new port?

@reneeotten
Copy link
Contributor

@gpanders - thanks for the PR! I would certainly like to stay the maintainer of these ports since they are dependencies of py-spyder. Setting the "original" ports to being "depracated with no upstream supports" is fine, once the Spyder project has released a version where they changed to the new dependencies, I will consider just removing the ports as nothing else depends on them.

A few request still:

  • can you please add the post-destroot parts in the new submissions, I would like to include the license file, readme and other relevant files that are part of it
  • please separate the commits such that each commit touches only one port

I'm a bit pre-occupied with familiy business right now so cannot promise that I will have time to follow-up on this soonish, but if you're willing to make the changes suggested above anyone with commit access should feel free to push the button!

@gpanders
Copy link
Contributor Author

gpanders commented Jul 16, 2021

A few request still:

  • can you please add the post-destroot parts in the new submissions, I would like to include the license file, readme and other relevant files that are part of it

  • please separate the commits such that each commit touches only one port

Done. Also, unless you object I just listed you as the sole maintainer on both py-python-lsp-server and py-python-lsp-jsonrpc.

Deprecated in favor of py-python-lsp-server.
@reneeotten reneeotten merged commit f1beb51 into macports:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: submission
Development

Successfully merging this pull request may close these issues.

4 participants