Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to get the changes of a specific commit id #13

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

AurelienFT
Copy link
Collaborator

This PR adds a methods get_changes() that allows you to get the changes committed at a certain id.

I have added documentation and tests on it in the PR if it's not clear do not hesitate to ask anything :)

@AurelienFT AurelienFT requested a review from tdelabro February 2, 2024 10:51
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (d2dd35d) 57.84% compared to head (a63fc25) 90.71%.
Report is 7 commits behind head on oss.

Files Patch % Lines
src/error.rs 0.00% 8 Missing ⚠️
src/trie/merkle_tree.rs 94.24% 8 Missing ⚠️
src/trie/path.rs 90.24% 8 Missing ⚠️
src/key_value_db.rs 84.84% 5 Missing ⚠️
src/trie/trie_db.rs 77.27% 5 Missing ⚠️
src/databases/hashmap_db.rs 0.00% 1 Missing ⚠️
src/databases/rocks_db.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              oss      #13       +/-   ##
===========================================
+ Coverage   57.84%   90.71%   +32.86%     
===========================================
  Files          11       17        +6     
  Lines         344     2154     +1810     
===========================================
+ Hits          199     1954     +1755     
- Misses        145      200       +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/tests/simple.rs Show resolved Hide resolved
src/tests/simple.rs Outdated Show resolved Hide resolved
@AurelienFT AurelienFT requested a review from tdelabro February 2, 2024 16:43
@tdelabro tdelabro merged commit 54d4336 into madara-alliance:oss Feb 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants