Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm compatibility #7

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Wasm compatibility #7

merged 10 commits into from
Jan 25, 2024

Conversation

0xLucqs
Copy link
Collaborator

@0xLucqs 0xLucqs commented Jan 15, 2024

replaces #3

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Test Results

23 tests   - 5   22 ✔️  - 6   0s ⏱️ ±0s
  2 suites ±0     1 💤 +1 
  1 files   ±0     0 ❌ ±0 

Results for commit 1992d59. ± Comparison against base commit 5c3f208.

This pull request removes 5 tests. 
trie::merkle_tree::tests ‑ multiple_commits_tree_compare
trie::merkle_tree::tests ‑ one_commit_tree_compare
trie::merkle_tree::tests ‑ simple_commits
trie::merkle_tree::tests ‑ simple_commits_and_delete
trie::merkle_tree::tests ‑ test_proof

♻️ This comment has been updated with latest results.

@0xLucqs 0xLucqs force-pushed the wasm_compatibility branch from 1acd670 to 8ce3932 Compare January 15, 2024 11:46
@0xLucqs 0xLucqs requested a review from tdelabro January 16, 2024 09:45
tdelabro
tdelabro requested changes Jan 16, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
rust-toolchain.toml Show resolved Hide resolved
rust-toolchain.toml Show resolved Hide resolved
src/changes.rs Show resolved Hide resolved
src/databases/hashmap_db.rs Outdated Show resolved Hide resolved
src/databases/hashmap_db.rs Show resolved Hide resolved
src/tests/madara_comparison.rs Show resolved Hide resolved
tdelabro
tdelabro requested changes Jan 16, 2024
View reviewed changes
.github/workflows/check_lint.yml Outdated Show resolved Hide resolved
.github/workflows/check_lint.yml Outdated Show resolved Hide resolved
.github/workflows/check_lint.yml Show resolved Hide resolved
ensure_no_std/Cargo.lock Show resolved Hide resolved
src/bonsai_database.rs Show resolved Hide resolved
src/bonsai_database.rs Show resolved Hide resolved
@tdelabro tdelabro mentioned this pull request Jan 25, 2024
Closed
@0xLucqs 0xLucqs force-pushed the wasm_compatibility branch 3 times, most recently from 9c4ef77 to 49036bb Compare January 25, 2024 10:30
@0xLucqs 0xLucqs force-pushed the wasm_compatibility branch 2 times, most recently from 41b53a9 to b5dd28b Compare January 25, 2024 10:40
@0xLucqs 0xLucqs force-pushed the wasm_compatibility branch from b5dd28b to 1992d59 Compare January 25, 2024 11:39
@tdelabro tdelabro merged commit 5b8b67a into oss Jan 25, 2024
7 checks passed
@tdelabro tdelabro deleted the wasm_compatibility branch January 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xLucqs @tdelabro @damip