Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower and ting #6

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Bower and ting #6

wants to merge 10 commits into from

Conversation

ninjabiscuit
Copy link

This pull request removes the frontend dependencies in vendor assets and includes them via bower. I've created a .bowerrc file to set up the desired location of the components in app/assets (maybe should be vendor assets?) and a component.json that specifies some default dependencies. This now allows us to control frontend dependencies in the same manner that we controll backend dependencies.

It does require the user to have bower installed and to run "bower install" after the generator has run. Maybe this can be automated?

I've also moved the top level partials to the application folder and out of the layouts folder - I think this makes more sense but - whatevs.

In addition I've made the changes that Chris and Callum and I discussed around lists / grids / helpers css.

Finally I made the generator amend development.rb to include the Sass config to allow source maps by default. Barlow thinks this is a bad thing to do - I'm open to discussion or better ways of doing this.

I realise now that I probably should have split all these changes out into different pull requests but I didn't so suck it.

@ninjabiscuit
Copy link
Author

Realised that there are two major issues with bower use.

  1. That we either need to include all the components in the git repo, or add a build step that runs bower then rake assets precompile. Without either of these solutions deployment would break. The first solution sucks because we would have to dump loads of stuff in GitHub. The second requires adding extra dependencies for build which feels nasty.
  2. If we need custom builds of projects like jQuery, Lodash, Modernizr or Ender then we would have to break the bower workflow. Bower doesn't currently handle custom builds of scripts well.

As such, I've taken out all the bower stuff for now and have reverted to standard script management techniques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant