Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NSSet and NSMutableSet #245

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add NSSet and NSMutableSet #245

merged 1 commit into from
Aug 29, 2022

Conversation

zleytus
Copy link
Contributor

@zleytus zleytus commented Aug 17, 2022

NSSet and NSMutableSet have a lot in common with NSArray and NSDictionary, so they were relatively straightforward to add.

Part of #67.

madsmtm
madsmtm reviewed Aug 17, 2022
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks really nice!

I don't have time for it right now, but will review it in about a week

@zleytus zleytus force-pushed the nsset branch 3 times, most recently from fb6408f to 282b0f7 Compare August 17, 2022 17:46
madsmtm
madsmtm requested changes Aug 17, 2022
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out, I got a bit of time to do it now: Looks really nice, especially cool with the detailed examples!

objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/set.rs Outdated Show resolved Hide resolved
objc2/src/foundation/mutable_set.rs Outdated Show resolved Hide resolved
@zleytus zleytus force-pushed the nsset branch 2 times, most recently from 44aa2ee to ade656c Compare August 20, 2022 19:37
madsmtm
madsmtm requested changes Aug 28, 2022
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one more thing then I think it's good to go

objc2/src/foundation/mutable_set.rs Outdated Show resolved Hide resolved
@zleytus
Copy link
Contributor Author

zleytus commented Aug 28, 2022

I just noticed this change 1b32385 for NSArray. NSSet has a similar test and I was wondering if I should make the same change.

@madsmtm
Copy link
Owner

madsmtm commented Aug 29, 2022

Yeah, NSSet seems to behave similarly on my old iPad, it would be nice if you did the same as in that commit

madsmtm
madsmtm approved these changes Aug 29, 2022
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your work and quick responses! (I'll merge as soon as CI finishes)

@madsmtm madsmtm mentioned this pull request Aug 29, 2022
Closed
34 tasks
@madsmtm madsmtm merged commit 9ab6bf3 into madsmtm:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zleytus @madsmtm