Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NSMutableDictionary #249

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add NSMutableDictionary #249

merged 1 commit into from
Aug 29, 2022

Conversation

zleytus
Copy link
Contributor

@zleytus zleytus commented Aug 29, 2022

It makes sense to add NSMutableDictionary to go with NSDictionary.

Part of #67.

@zleytus zleytus force-pushed the nsmutabledict branch 3 times, most recently from 3984990 to 3abaa22 Compare August 29, 2022 05:42
madsmtm
madsmtm approved these changes Aug 29, 2022
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor nits.

Out of curiosity, may I ask your reasoning for contributing to this repo? I couldn't find a project on your GitHub page, but I assume you need this for something?

objc2/src/foundation/mutable_dictionary.rs Show resolved Hide resolved
objc2/src/foundation/mutable_dictionary.rs Outdated Show resolved Hide resolved
objc2/src/foundation/mutable_dictionary.rs Outdated Show resolved Hide resolved
objc2/src/foundation/mutable_dictionary.rs Outdated Show resolved Hide resolved
@zleytus
Copy link
Contributor Author

zleytus commented Aug 29, 2022

I'm planning to use this library to wrap CoreWLAN and eventually write a cross-platform Wi-Fi library. CoreWLAN returns Wi-Fi scan results in an NSSet, which explains why I contributed that first. I don't think I'll personally need NSMutableDictionary, but I just find adding functionality from Foundation to be interesting and hopefully useful to others.

@madsmtm
Copy link
Owner

madsmtm commented Aug 29, 2022

Oooh, interesting! Do drop me a note somewhere when you have something to show, I would be glad to give it a soundness review.

@madsmtm madsmtm merged commit b4c7c69 into madsmtm:master Aug 29, 2022
@zleytus
Copy link
Contributor Author

zleytus commented Aug 30, 2022

Definitely! That would be great.

@madsmtm madsmtm mentioned this pull request Aug 31, 2022
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zleytus @madsmtm